GrayShadow's 'Giving Gogo Magic' code

[DrakeyC]

So what do I need to do to try? Even if you're not sure, I have a backup so what have I got to lose? I'd like SOMETHING to go right today.

EDIT - If you mean the 08 at C0/D691 should be 04, mine is.

[Gi Nattak]

No not that, I see in the asm file you edited that was changed.
I said this: CMP $1608,Y ; Check against current level.
In the RelmRecruit section.
You should take a bit of time to read carefully exactly what was said, please lol.

Do a search (cntr f) for CMP $1608,Y if you can't find it manually there, although I can't imagine why not.
Might try changing that 1608 to 1604. Though like I say this might not be directly related to Relm at all, just that 08 there seems like it to me and since it's in the 'RelmRecruit' section.

[Gi Nattak]

Shit yeah that's not gonna work actually, it's something related to all characters learning not just relm, as it's used for the other characters I see now.

Hmm well I'm out of ideas at the moment to try >_< My lack of assembly know-how limits me greatly!

[DrakeyC]

Well, Edgar doesn't have any other "learn by level" abilities (he has Summon), if that knowledge helps at all.

[Gi Nattak]

That one 08 at C0/D691 is the only thing I can spot that seems like changing it should work, but I guess there's more to it. A coder like Madsiur etc. might be able to notice something else, why it's not working. As for me though I must bow out gracefully I'm afraid lol.

[madsiur]

Although, Gi said to use 0E?

He's right and wrong. I had in mind your character to get magic was $0C but it's $0D, right? Branching for character $0E and above is correct but this has a consequence of having chars $0C and $0D learn magic. There's not enought SRAM for that, well not in the way GrayShadow designed his hack.

EDIT - Didn't work. Started a new game, Edgar has no natural magic.

Obviously you have problems with applying the patch. My statement was referring to your characters having garbage value is his magic table. Did the garbage disappeared? Yes? ok.

[DrakeyC]

Nope, patch was fine. I double-checked the indicated values in the patch notes on my rom, they say what they should.

As for the garbage, impossible to say until I get to recruiting Umaro again.

[madsiur]

As for natural magic not working for Edgar, you might need to change this as well in the 'RelmRecruit' section:
CMP $1608,Y      ; Check against current level.

This should stay the same it has nothing to do with the character ID.

You should have two thing to modify:

Code:

CMP #$08         ;  
BEQ RelmRecruit  ; If Relm, branch.

Code:

CMP #$08         ; 
BEQ LvlUpMagic   ; Branches to teach natural magic.

Edit: You character should also have the magic command from the start.

[DrakeyC]

Well, they do have the Magic command assigned. Does it just not appear until the Zozo event? Because the things you listed as needing to change, I already had changed originally.

[madsiur]

You need to point an instruction of the code to your character SRAM spell block:

For Relm:

Code:

STA $1C1E,Y      ; Teach it.

Each block is $36 bytes. Terra block start at $1A6E. Just do $1A6E + (character ID * $36).

ID | block
$01 | $1AA4
$02 | $1ADA
etc.