Users browsing this thread: 1 Guest(s)
Condensing Spell List in Battle
10-04-2017, 08:44 PM
GrayShadows Wrote:By that same virtue, I think it would even be safe to skip CPY #$0138 / BNE .checkLoreLoop and just BRA .checkLoreLoop instead; again, we're spending a few extra cycles before we exit (at Y = #$013C in .findNextLore), but it's another three bytes of space saved that can be used for other patches. Unless I'm missing something there?
i think ending the Lore list on a non-null entry would be problematic. we can get away with ending the Magic list this way, because:
me Wrote:- involve us finishing the original list on non-null entries, so the check at the top of the main loop (.checkLoreLoop) will fail, branching to .checkNextLore at the end of the loop -- bringing both X and Y to the start of the Lore list (or exiting, if we were processing lores).
iow, .findNextLore is a situational loop within the main loop, but we still need _something_ to tell that main loop to end.
« Next Oldest | Next Newest »
Users browsing this thread: 1 Guest(s)