Copying to your ROM a song available on the Forum

Maybe try not moving the song pointers? If you are moving instrument data then there is no need to move song pointers, as they can just expand into the space that instrument data was previously using. I had a lot of trouble with getting relocated song pointers to work, and eventually realized that it was a totally unnecessary step and stopped trying and all my problems went away. I don't actually remember *what* the problems I was having were, though ...

Also, make sure it works without the new background music asm hack first before testing with it. Change $C2BF3B from 24 to 56 and get into a battle, for example.

And make sure the battle you're using for testing actually has music normally!

Wow, you are absolutely right!  Step #3 is redundant if you have to move the instrument data (except for increasing the songs from 55 to 56).

Unfortunately though, I still can't get the track to play.  The overworld theme continues playing in the battle without interruption (like it would on the Veldt).  I tried this test on a vanilla 1.0 ROM, and I used your idea by changing the main battle theme from 24 to 56 at $C2BF3B.

Test the ASM hack alone then test adding a new song. This is how you test. If you have problems with 2 hacks simultaneously, test one thing at the time. Your hex looks fine but I don't have time to look at it byte by byte.

I did test your hack first. It works fine.  I guess you didn't see my edit last night to my post?  I put up a bunch of screenshots underlining each byte I changed so you didn't have to go through my code byte by byte.  Since emberling pointed out that I no longer have to move the song pointers, some of this code has changed in the screenshots, but I will repost them with some new questions to make sure I did this right.



Ignore the location on this screenshot, since I have now moved it back to the original place, but is my code underlined at the bottom correct? This is supposed to point to the new song data, but I want to make sure the format is correct. See the next screenshot for the song data location.



The song data that I'm trying to add (the location is underlined):



The new song ID limit changed to 56:


This is where I relocated the instrument code (location underlined).


This is the very end of the Instrument code.  The underlined part at the end of the block is the 32 bytes of code for the new song I added.  Is this the right place for it?



This is where I changed the reference to the new location of the instrument block: