Users browsing this thread: 1 Guest(s)
Random battle theme

#38
Posts: 315
Threads: 20
Thanks Received: 0
Thanks Given: 2
Joined: Dec 2017
Reputation: 2
Status
None
(10-17-2018, 10:48 PM)madsiur Wrote: Note that if you add a lot you can simplify the code by having a table of $37 bytes with song IDs ($FF for current music) and load that single byte instead of a lot of CMPs and branches.

Hey Madsiur, I think we have to use your suggestion here, because I am now having an error when I compile the code (I think there are too many backgrounds used now).  Can you help me simplify the code as you suggested?  Here is how my code currently looks:

Code:
hirom
header

org $C2BDB7
JSR free_space
NOP

org $C264C9          ; change to free space
free_space:
LDA $C2BF3B,X
CMP #$24             ; check if battle song
BNE exit             ; branch if not
LDA $11E2            ; load battle background byte
AND #$3F             ; isolate battle background
BEQ is_wor_grass
CMP #$01
BEQ is_wob_forest
CMP #$02
BEQ is_wob_desert
CMP #$03
BEQ is_wor_forest
CMP #$05
BEQ is_wob_grass
CMP #$2F
BEQ is_wor_desert
CMP #$16
BEQ is_kefka1
CMP #$28
BEQ is_kefka2
CMP #$15
BEQ is_floating_island
CMP #$0B
BEQ is_mountain
CMP #$0C
BEQ is_mountain
CMP #$1D
BEQ is_magitek
CMP #$1B
BEQ is_research
CMP #$14
BEQ is_kefka_interior
CMP #$27
BEQ is_castle
CMP #$1A
BEQ is_castle
CMP #$1C
BEQ is_colosseum
LDA #$24             ; default battle song ID
BRA exit
is_wob_grass:
LDA #$55             ; song ID (WOR Grass) 55
BRA exit
is_wob_forest:
LDA #$57             ; song ID (WOR Forest) 57
BRA exit
is_wob_desert:
LDA #$66             ; song ID (W O B Desert)
BRA exit
is_wor_forest:
LDA #$5B             ; song ID (W O B Forest)
BRA exit
is_wor_grass:
LDA #$56             ; song ID (W O B Grass) 56
BRA exit
is_wor_desert:
LDA #$5D             ; song ID (WOR Desert) 5D
BRA exit
is_kefka1:
LDA #$59             ; song ID (Kefka Tower 1)
BRA exit
is_kefka2:
LDA #$59             ; song ID (Kefka Tower 2)
BRA exit
is_floating_island:
LDA #$62             ; song ID (Floating Continent)
BRA exit
is_mountain:
LDA #$61             ; song ID (Mountain outside and inside)
BRA exit
is_magitek:
LDA #$64             ; song ID (Magitek Generic)
BRA exit
is_research:
LDA #$5F             ; song ID (Magitek Tube Research)
BRA exit
is_kefka_interior:
LDA #$58             ; song ID (Kefka Tower Interior)
BRA exit
is_castle:
LDA #$6A             ; song ID (Ancient Castle)
BRA exit
is_colosseum:
LDA #$5C             ; song ID (Colosseum)
exit:
RTS
  Find
Quote  



Messages In This Thread
Random battle theme - by madsiur - 01-13-2014, 07:47 PM
RE: Random battle theme - by Lockirby2 - 01-13-2014, 09:48 PM
RE: Random battle theme - by madsiur - 01-13-2014, 10:11 PM
RE: Random battle theme - by SSJ Rick - 01-14-2014, 03:58 AM
RE: Random battle theme - by B-Run - 01-20-2014, 09:54 PM
RE: Random battle theme - by Gi Nattak - 09-02-2014, 07:19 PM
RE: Random battle theme - by emberling - 10-13-2018, 03:27 PM
RE: Random battle theme - by Lightning - 10-13-2018, 01:28 PM
RE: Random battle theme - by Gi Nattak - 10-13-2018, 01:58 PM
RE: Random battle theme - by Lightning - 10-13-2018, 02:15 PM
RE: Random battle theme - by madsiur - 10-13-2018, 02:27 PM
RE: Random battle theme - by Lightning - 10-13-2018, 02:33 PM
RE: Random battle theme - by madsiur - 10-13-2018, 02:52 PM
RE: Random battle theme - by Lightning - 10-13-2018, 03:20 PM
RE: Random battle theme - by madsiur - 10-13-2018, 03:52 PM
RE: Random battle theme - by Lightning - 12-07-2018, 03:46 AM
RE: Random battle theme - by Lightning - 10-13-2018, 05:25 PM
RE: Random battle theme - by madsiur - 10-13-2018, 10:16 PM
RE: Random battle theme - by Lightning - 10-13-2018, 11:45 PM
RE: Random battle theme - by madsiur - 10-14-2018, 12:04 AM
RE: Random battle theme - by Lightning - 10-14-2018, 02:33 PM
RE: Random battle theme - by madsiur - 10-14-2018, 03:07 PM
RE: Random battle theme - by Lightning - 10-14-2018, 03:12 PM
RE: Random battle theme - by madsiur - 10-14-2018, 03:16 PM
RE: Random battle theme - by Lightning - 10-14-2018, 04:05 PM
RE: Random battle theme - by madsiur - 10-14-2018, 07:11 PM
RE: Random battle theme - by Lightning - 10-15-2018, 04:11 AM
RE: Random battle theme - by madsiur - 10-16-2018, 11:48 AM
RE: Random battle theme - by Lightning - 10-17-2018, 04:51 PM
RE: Random battle theme - by Gi Nattak - 10-17-2018, 05:28 PM
RE: Random battle theme - by Lightning - 10-17-2018, 07:22 PM
RE: Random battle theme - by madsiur - 10-17-2018, 10:48 PM
RE: Random battle theme - by Lightning - 10-17-2018, 11:21 PM
RE: Random battle theme - by Lightning - 12-14-2018, 03:52 AM
RE: Random battle theme - by madsiur - 12-11-2018, 03:52 PM
RE: Random battle theme - by Lightning - 12-11-2018, 06:11 PM
RE: Random battle theme - by madsiur - 12-11-2018, 06:23 PM
RE: Random battle theme - by Lightning - 12-11-2018, 09:21 PM
RE: Random battle theme - by Lightning - 12-14-2018, 02:41 PM
RE: Random battle theme - by madsiur - 12-14-2018, 11:23 AM
RE: Random battle theme - by madsiur - 12-14-2018, 03:16 PM
RE: Random battle theme - by Lightning - 12-14-2018, 03:28 PM
RE: Random battle theme - by madsiur - 12-14-2018, 04:53 PM
RE: Random battle theme - by Lightning - 12-14-2018, 05:45 PM
RE: Random battle theme - by madsiur - 12-14-2018, 08:10 PM
RE: Random battle theme - by Lightning - 12-14-2018, 09:58 PM
RE: Random battle theme - by Lightning - 07-11-2021, 03:22 PM
RE: Random battle theme - by madsiur - 07-11-2021, 03:52 PM
RE: Random battle theme - by Lightning - 07-11-2021, 04:11 PM
RE: Random battle theme - by madsiur - 07-11-2021, 04:21 PM
RE: Random battle theme - by Lightning - 07-11-2021, 04:41 PM
RE: Random battle theme - by madsiur - 07-11-2021, 05:46 PM
RE: Random battle theme - by Lightning - 07-11-2021, 07:48 PM
RE: Random battle theme - by madsiur - 07-11-2021, 08:34 PM
RE: Random battle theme - by Lightning - 07-12-2021, 10:49 AM

Forum Jump:

Users browsing this thread: 1 Guest(s)


Theme by Madsiur2017Custom Graphics by JamesWhite