Class Names function

Necropost!

Hey, so I was playing around with this and I've found a few bugs with it. Hopefully there are some people around who may be able to provide some insight.

1. Like someone noticed before, the class name display in the Skills menu is all kinds of screwed up. It is positioned between HP and MP and only partially visible. This seems to be a bug, rather than just faulty positioning data, from what I can tell.
2. The class name display obscures the "LV" on the Lineup menu (when selecting party members, on the airship for example). This seems reasonable, since those are displayed on the same line. Reworking the menu is needed, like SilentEnigma did with the updated Restored Ability Names patch.
3. There is no class name display on the Status submenu - even though the Status menu does show current statuses (like Float and Imp) after the character name. I'm not sure why. Anyone?

I was poking around because I was wondering what the problem was with the cut off class names in the Skills menu. This problem occurs with or without Catone's edits (which concern the positioning of the Status display in the main menu).
From what I understand, Madsiur's code makes use of the code to display a character's status ailment. It tacks on a routine to display class name if no status is found (like what was dummied out of FF6j).

This problem occurs seemingly because the Skills menu also calls code to display the character's status, but I don't know why exactly.

This is where the Skills menu calls the code to display the current Status:

Code:

C3/4EED: A0DD42   LDY #$42DD
C3/4EF0: A2504F   LDX #$4F50     (4F is the X position and 50 is the Y position)
C3/4EF3: 202734   JSR $3427      (display current status ailments)

Normally, a status icon is displayed in the lower left corner of the box that displays LV, HP, MP and equipped Esper. You can change the position of the status icon, but it won't affect the display of the class name, unfortunately.

A quick and dirty fix to the problem is to simply not display status in the Skills menu at all. Branch over the above code, or replace it with NOPs (or change its call to $34E5 instead, which is just an RTS).

Interesting note: The only good reason to show status in the Skills menu is to remind you that the reason you can't cast spells is because you're an Imp, but the portrait does that anyway. This may be a relic from an earlier design in which Mute was supposed to be an out-of-battle status. That may be why Echo Screen is usable out of battle, too.

---

UPDATE:

Okay, so after poking around a bit more, I can say that I was wrong and that faulty positioning data is (part of) the problem here.

A bit more information: Function $3427 in C3 is the function to determines which status, if any, to display. It is this function that Madsiur's code hooks in to. Going into this function, the Y register holds (16-bit) positioning data. These are the numbers Catone suggested changing to display class names properly in the main menu.

The data is a 16-bit number and I am not exactly sure about the format, but as far as I can determine, increasing this number simply makes the string display further right on the screen, eventually wrapping around to the next "row" below and starting again from the left. It also only seems to work properly in increments of two: in increments of one, the text string becomes garbled.

Anyway, properly positioning of the string in the Skills menu requires this change:

Code:

C3/4EED:    A09D43      LDY #$439D   (this positions the text string in the lower left corner of the LV/HP/MP/Equipped esper window)

This unfortunately reveals a new problem, that I think is best described by a picture. 
Unfortunately, I have no idea what causes this, the same way I have no idea why the text gets cut off horizontally when something on the same "row" partially overlaps it.

Going into $3427, 16-bit X also holds positioning data, for the status icons. Interestingly, it is handled differently; the low byte is horizontal positioning and the high byte is vertical positioning.

Code:

C3/4EF0:    A2504F      LDX #$4F50   (this is the default position of the status icons; the lower left corner)
C3/4EF3:    202734      JSR $3427      (display current status ailments)