Casting Spells Taught by Espers - RESOLVED!

Thank you so much for the second pair of eyes. I appreciate all of this free help. I'm going to have to credit you as a co-author if I ever get this done

Code:

C2/55A3: EA              NOP
C2/55A4: EA              NOP
C2/55A5: EA              NOP
C2/55A6: EA              NOP

This sets all spells as potentially known by at least someone. While not game-breaking, this will make it so your list doesn't condense, meaning you will sometimes have large gaps in between spells. Also, i think this will give Gogo all magic during battle, which won't translate to outside of battle... i *think* anyway.

True, but I am still at the "see if I can get this to work phase." My hope is to make the added code (or a modified version) a subroutine, as it would have to be called for both loops (since the first loop would exclude the spells by default. However, I wanted to see if I could get it to work with no restrictions first.

The only thing I won't like is that Gogo will still get the benefit of using spells that aren't fully learned by other characters. Since Gogo can mimic everything, though, there's no reason to restrict him aside from balance.

The only thing that jumps out at me here is the order you return items from the stack, you have a Y already there, then you push X then Y.... so when you are recalling the values from the stack they should be Y,X,Y. you currently have X,Y,Y which means you are exiting with the wrong X value.

At a glance, everything else seems to check out.

Happy Hacking!

Believe it or not this was the key to solving everything.

There was another BIG mistake I made, but by fixing the stack issue, the breakpoints I added returned more sensical, if unexpected, values.  From there I was able to realize I used the wrong CMP. I should have used the C3, not D3, and I corrected it with this line.

Code:

C2/647F: C3 01           CMP ($01,s)

Thank you so much! I wouldn't have gotten this far without you.