FF6LE Rogue CE / Zone Doctor CE

Found a bug with ZD CE v0.1 using non expanded ROM:

Code:

ZONEDOCTOR, Version=3.18.4.0, Culture=neutral, PublicKeyToken=null, ROMSize=$400000

**************Exception Text**************
Method not found: '!!0[] System.Array.Empty()'.
  at ZONEDOCTOR.Search..ctor(ToolStripNumericUpDown searchIndexNum, ToolStripTextBox searchField, ToolStripButton searchButton, IList names)
  at ZONEDOCTOR.Locations..ctor()
  at ZONEDOCTOR.Program.CreateLocationsWindow()

**************Recent Event History**************
LOADED ZONE DOCTOR APPLICATION
CLOSED FORM "Editor"
"romInfo" | Text = "FINAL FANTASY 3      
True
0xD..." | Form "Editor"
LOADED ZONE DOCTOR APPLICATION
***EXCEPTION*** Method not found: '!!0[] System.Array.Empty()'.)
***EXCEPTION*** Method not found: '!!0[] System.Array.Empty()'.)
***EXCEPTION*** Method not found: '!!0[] System.Array.Empty()'.)
***EXCEPTION*** Method not found: '!!0[] System.Array.Empty()'.)

Did you do that with the search list or the search Textbox? http://i1198.photobucket.com/albums/aa44...g7c5uy.png

Also, I saw the function had a call in the event editor, this area is out of my range since it is known to be buggy.

No, it happen as soon as I click on either Locations or Event Script.

That is strange I can't replicate it...

Tried original FF3 ROM v1.0, 1.1, my hack (patched and not patched, expanded and non-expanded), no ROMS actually works, they all provoke a Method not found error

Code:

**************Exception Text**************
Method not found: '!!0[] System.Array.Empty()'.
  at ZONEDOCTOR.Search..ctor(ToolStripNumericUpDown searchIndexNum, ToolStripTextBox searchField, ToolStripButton searchButton, IList names)
  at ZONEDOCTOR.Locations..ctor()
  at ZONEDOCTOR.Program.CreateLocationsWindow()

Maybe I need specific libraries? or need to update my .NET libraries?

Edit: There you go, I updated .NET Framework to 4.6.1 and the error is gone. This is kind of important to know what version is needed to make it work because I had 4.x.x installed already. I will report if I find something else.

This is kind of important to know what version is needed to make it work because I had 4.x.x installed already.

Yes I will specify it. I updated the target Framework without really wondering if it would have any impact.

Getting some errors while looking at maps/exits/events:

#1 (ZDCE): Map 14E (Kefka Tower, Outside) and this error appear when I click on Exit #7:
This bug also happen to many other exits but not all.

Code:

ZONEDOCTOR, Version=3.18.4.0, Culture=neutral, PublicKeyToken=null, ROMSize=$400000

**************Exception Text**************
Index was outside the bounds of the array.
  at ZONEDOCTOR.ScriptsEditor.Commands.Interpreter.GetLocationName(UInt16 value)
  at ZONEDOCTOR.ScriptsEditor.Commands.Interpreter.InterpretCommand(EventCommand esc)
  at ZONEDOCTOR.Do.EventScriptToText(EventScript eventScript, Int32 offset, Int32 lines, Int32 length)
  at ZONEDOCTOR.Overlay.DrawLocationNPCTag(Graphics g, LocationNPCs npcs, NPC npc, Int32 index, NPC parent, Int32 z)
  at ZONEDOCTOR.Overlay.DrawLocationNPCTags(Graphics g, LocationNPCs npcs, Int32 z)
  at ZONEDOCTOR.TilemapEditor.pictureBoxLocation_Paint(Object sender, PaintEventArgs e)

**************Recent Event History**************
"exitListBox" | "EXIT #7 | Form "Locations" | Element = {334}  [$14E] Kefka's Tower, Outside
"exitListBox" | "EXIT #2 | Form "Locations" | Element = {334}  [$14E] Kefka's Tower, Outside
"buttonToggleExits" | Form "Locations" | Element = {334}  [$14E] Kefka's Tower, Outside
"layerPrioritySet" | Value = 5 | Form "Locations" | Element = {334}  [$14E] Kefka's Tower, Outside
"buttonToggleSolidity" | Form "Locations" | Element = {001}  [$001] World of Ruin, World Map
"buttonToggleSolidity" | Form "Locations" | Element = {001}  [$001] World of Ruin, World Map
"exitListBox" | "EXIT #38 | Form "Locations" | Element = {001}  [$001] World of Ruin, World Map
"pictureBoxTilesetL1" | MouseDown = (X:91,Y:139) | Form "Locations" | Element = {001}  [$001] World of Ruin, World Map
"openLocations" | Form "Editor"
OPENED FORM "Locations"

#2 (ZDCE): Getting ERROR: OUT OF BOUNDS INDEX message on a lot of EXITS, the message appear next to each exits on the map. All others EXITS have wrong destinations. EVENTS looks fine but I didn't check a lot of them. Vanilla ROM

#3 Bug with FF3LECE v0.75: when loading map editor, this message appear: Error reading short from byte[] data at offset 119D1AF data size: 400000 (this also happen with an original FF3 ROM), then the following message appear:

Code:

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.Exception: Exception of type 'System.Exception' was thrown.
  at FF3LE.ByteManage.GetShort(Byte[] data, Int32 offset)
  at FF3LE.LCDecomp.Decompress(Int32 offset, Int32 length, UInt16& totalSize)
  at FF3LE.Levels.DecompressLevelData()
  at FF3LE.Levels..ctor(Model model)
  at FF3LE.Program.CreateLevelsWindow(Int32 iExpBank)
  at FF3LE.Form1.button3_Click(Object sender, EventArgs e)
  at System.Windows.Forms.Control.OnClick(EventArgs e)
  at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
  at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
  at System.Windows.Forms.Control.WndProc(Message& m)
  at System.Windows.Forms.ButtonBase.WndProc(Message& m)
  at System.Windows.Forms.Button.WndProc(Message& m)
  at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
----------------------------------------
FF6LE
   Assembly Version: 2.1.0.0
   Win32 Version: 2.1.0.0
   CodeBase: file:///D:/Archives/FF3-WE/FF6LE-CE_x64.exe
----------------------------------------
System
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Windows.Forms
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System.Drawing
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
Accessibility
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------
System.Configuration
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Xml
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Xml.Linq
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml.Linq/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.Linq.dll
----------------------------------------
System.Core
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
   <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

#4 Bug with FF3LECE v0.75 when saving the ROM following a MAP expansion, probably caused by bug #3: 

Code:

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.ArgumentOutOfRangeException: Index and length must refer to a location within the string.
Parameter name: length
  at System.String.Substring(Int32 startIndex, Int32 length)
  at FF3LE.Model.SaveXML()
  at FF3LE.Program.SaveRomFile()
  at FF3LE.Form1.saveToolStripMenuItem_Click(Object sender, EventArgs e)
  at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
  at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
  at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
  at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
  at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
  at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
  at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
  at System.Windows.Forms.Control.WndProc(Message& m)
  at System.Windows.Forms.ToolStrip.WndProc(Message& m)
  at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
  at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.NET/Framework64/v4.0.30319/mscorlib.dll
----------------------------------------
FF6LE
   Assembly Version: 2.1.0.0
   Win32 Version: 2.1.0.0
   CodeBase: file:///D:/Archives/FF3-WE/FF6LE-CE_x64.exe
----------------------------------------
System
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Windows.Forms
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System.Drawing
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
Accessibility
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------
System.Configuration
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Xml
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Xml.Linq
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml.Linq/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.Linq.dll
----------------------------------------
System.Core
   Assembly Version: 4.0.0.0
   Win32 Version: 4.6.1055.0 built by: NETFXREL2
   CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
   <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Looks like something broke with LECE v0.75/ZDCE v0.1

#3 Bug with FF3LECE v0.75: when loading map editor, this message appear: Error reading short from byte[] data at offset 119D1AF data size: 400000 (this also happen with an original FF3 ROM), then the following message appear:

I recreated this an it happen when you have a valid XML file path and you load a vanilla ROM. There's nothing I can do about this. You need to blank out the filepath in the settings window in order to use your vanilla ROM. Your Zone Doctor issues could be caused by this too. I will however take a look at ZD later.

#4 Bug with FF3LECE v0.75 when saving the ROM following a MAP expansion, probably caused by bug #3: 

I fixed this and two other things I forgot when I moved some code.

I recreated this an it happen when you have a valid XML file path and you load a vanilla ROM. There's nothing I can do about this. You need to blank out the filepath in the settings window in order to use your vanilla ROM. Your Zone Doctor issues could be caused by this too. I will however take a look at ZD later.

I deleted the XML file and the problems is gone with FF3LECE 0.75. The error message that was showing when selecting some maps in Zone Doctor is gone too but I'm still getting the ERROR: OUT OF BOUNDS INDEX message next to many Exits on the map and many Exits leads to wrong destinations. I used many different ROMs and they all show the same problems.

Everything has worked great for me, if anyone is having trouble getting it to work they should just make sure that nothing is being used in whatever space they decide to use for the expansion.

Also, I would suggest starting over with fresh test saves after you do the chest expansion. All the default chest bits were moved by 20 spots which will cause issues with already started games that had different chest bits used. The result will be some treasures that will not be obtainable.

Thanks for all your hard work on this Madsiur!