Pony Fantasy VI Remake

I copied the code as you posted it. Beyond that I have no idea what the asm shorthand you're using means. I'll try to EA the stuff I think you said, though.

EDIT - EA'd C2/0D1E to C2/0D21. Seems to work to reduce physical damage only. So, cool. From my understanding that's a more reliable fix than mine?

You wrote EA to C2/0D1E through C2/0D21, and now Morph halves physical damage taken? And you DIDN'T write EA to C2/0D15 - C2/0D16?
The behaviour in vanilla is "halve magical damage only". NOPing the part of the code that actually does the halving should disable all damage reduction from Morph, magical or otherwise.

Then it seems likely that you've applied a patch that makes changes to damage modification, and it just so happened that what you changed fixed what you wanted to fix.  Maybe. I don't know what HatZen changed in his old patch, so you'd best ask him what this change might entail. It's possible that you didn't fix it completely. Try it on both big damage numbers and small and see.

If HatZen's old patch changed this code, and the new patch doesn't, then patching the new patch over the old will leave stuff in from the old patch. That's just how IPS files work, they only transfer things that are different between the original and modified file.

You seem satisfied with the changes though so I won't dig deeper into this. Though if you later find that you're having problems related to damage modification, you'd best ask HatZen about it. His new patch doesn't have his old source files so I can't tell what the old patch changed and what the code looks like.


Here's the full damage modification function from vanilla. You can compare your ROM with this and see which addresses are different, if any.

Code:

[color=#000000]Damage modification (Randomness, Row, Self Damage, and more)

C2/0C9E: 08           PHP
C2/0C9F: C2 20        REP #$20
C2/0CA1: AD B0 11     LDA $11B0      (Maximum Damage)
C2/0CA4: 85 F0        STA $F0
C2/0CA6: E2 20        SEP #$20       (Set 8-bit Accumulator)
C2/0CA8: AD 14 34     LDA $3414
C2/0CAB: D0 03        BNE $0CB0
C2/0CAD: 4C 3B 0D     JMP $0D3B      (Exit if $3414 = 0)
C2/0CB0: 20 5A 4B     JSR $4B5A      (Random number 0 to 255)
C2/0CB3: 09 E0        ORA #$E0       (Set bits 7,6,5; bits 0,1,2,3,4 are random)
C2/0CB5: 85 E8        STA $E8        (Random number [224..255])
C2/0CB7: 20 3D 0D     JSR $0D3D      (Damage randomness)
C2/0CBA: 18           CLC
C2/0CBB: AD A3 11     LDA $11A3
C2/0CBE: 30 04        BMI $0CC4      (Branch if Concern MP)
C2/0CC0: AD A2 11     LDA $11A2
C2/0CC3: 4A           LSR            (isolate magical vs. physical property)
C2/0CC4: AD A2 11     LDA $11A2
C2/0CC7: 89 20        BIT #$20
C2/0CC9: D0 57        BNE $0D22      (Branch if ignores defense)
C2/0CCB: 08           PHP            (save Carry flag, which equals
                                     (physical attack) AND NOT(Concern MP) )
C2/0CCC: B9 B9 3B     LDA $3BB9,Y    (Magic Defense)
C2/0CCF: 90 03        BCC $0CD4      (Branch if concern MP or Magical damage)
C2/0CD1: B9 B8 3B     LDA $3BB8,Y    (Defense)
C2/0CD4: 1A           INC
C2/0CD5: F0 10        BEQ $0CE7      (Branch if = 255)
C2/0CD7: EB           XBA
C2/0CD8: AD 82 3A     LDA $3A82
C2/0CDB: 2D 83 3A     AND $3A83
C2/0CDE: 30 03        BMI $0CE3      (If Blocked by Golem or Dog, defense = 192)
C2/0CE0: A9 C1        LDA #$C1
C2/0CE2: EB           XBA
C2/0CE3: EB           XBA
C2/0CE4: 3A           DEC
C2/0CE5: 49 FF        EOR #$FF
C2/0CE7: 85 E8        STA $E8        (= 255 - Defense)
C2/0CE9: 20 3D 0D     JSR $0D3D      (Multiply damage by (255 - Defense) / 256 ,
                                     then add 1)
C2/0CEC: A3 01        LDA $01,S
C2/0CEE: 4A           LSR
C2/0CEF: B9 F8 3E     LDA $3EF8,Y    (Status byte 3)
C2/0CF2: B0 01        BCS $0CF5      (Branch if physical attack without Concerns MP)
C2/0CF4: 0A           ASL
C2/0CF5: 0A           ASL
C2/0CF6: 10 07        BPL $0CFF      (Branch if no Safe / Shell on target)
C2/0CF8: A9 AA        LDA #$AA
C2/0CFA: 85 E8        STA $E8
C2/0CFC: 20 3D 0D     JSR $0D3D      (Multiply damage by 170 / 256 , then add 1)
C2/0CFF: 28           PLP
C2/0D00: 90 15        BCC $0D17      (Skip row check if magical attack or Concern MP)
C2/0D02: B9 A1 3A     LDA $3AA1,Y
C2/0D05: 89 02        BIT #$02
C2/0D07: F0 04        BEQ $0D0D      (Branch if target not defending)
C2/0D09: 46 F1        LSR $F1
C2/0D0B: 66 F0        ROR $F0        (Cut damage in half)
C2/0D0D: 89 20        BIT #$20       (Check row)
C2/0D0F: F0 11        BEQ $0D22      (Branch if target in front row)
C2/0D11: 46 F1        LSR $F1
C2/0D13: 66 F0        ROR $F0        (Cut damage in half)
C2/0D15: 80 0B        BRA $0D22      (Skip morph if physical attack)
C2/0D17: B9 F9 3E     LDA $3EF9,Y
C2/0D1A: 89 08        BIT #$08
C2/0D1C: F0 04        BEQ $0D22      (Branch if target not morphed)
C2/0D1E: 46 F1        LSR $F1
C2/0D20: 66 F0        ROR $F0        (Cut damage in half)
C2/0D22: C2 20        REP #$20       (Set 16-bit Accumulator)
C2/0D24: AD A4 11     LDA $11A4
C2/0D27: 4A           LSR
C2/0D28: B0 0A        BCS $0D34      (Branch if heal; heal skips self damage theory)
C2/0D2A: C0 08        CPY #$08
C2/0D2C: B0 06        BCS $0D34      (Branch if target is a monster)
C2/0D2E: E0 08        CPX #$08
C2/0D30: B0 02        BCS $0D34      (Branch if attacker is monster)
C2/0D32: 46 F0        LSR $F0        (Cut damage in half if party attacks party)
C2/0D34: A5 F0        LDA $F0    
C2/0D36: 20 0B 37     JSR $370B      (Increment damage using $BC)
C2/0D39: 85 F0        STA $F0
C2/0D3B: 28           PLP
C2/0D3C: 60           RTS